It's all dependent on the socket bonus. If the bonus is worth going for (normally 120 str), then it is best to use orange (str/crit) gems in red sockets, and crit gems in yellow sockets. Blue sockets can be tricky, if you can get away with reforging out of the extra hit rating, pick up the green (crit/hit/) gems in blue. If a bonus is less than ~60-80 str (don't remember the exact number, but I can get it for you later if you'd like), then gem all yellow gems.
A bigger concern, is that at 504, you should not be prioritizing crit rating yet. Haste is a much more valuable stat until a higher