Redfella's DW Frost WeakAuras

[Redfella 51]

Coulf you paste those 4 rows from your WeakAuras.lua so I could easily pinpoint the issue?

[Mastermind76 2]

Message: [string "return function()..."]:2: attempt to compare nil with number

Time: 08/08/15 01:21:34

Count: 1

Stack: [C]: ?

[string "return function()..."]:2: in function `trigger'

Interface\AddOns\WeakAuras\WeakAuras.lua:1906: in function `ScanEvents'

Interface\AddOns\WeakAuras\WeakAuras.lua:1820: in function `ForceEvents'

Interface\AddOns\WeakAuras\WeakAuras.lua:2350: in function `ScanForLoads'

...terface\AddOns\WeakAurasOptions\WeakAurasOptions.lua:8285: in function <...terface\AddOns\WeakAurasOptions\WeakAurasOptions.lua:8284>

 

Locals: 

 

I am receiving the same error on the first load.

[Mastermind76 2]

Here are those 4 lines from the lua that you asked for.  I am having the same problem.

 

Line 1906 if(data.trigger(event, arg1, arg2, ...)) then

Line 1820       WeakAuras.ScanEvents(event);

Line 2350    WeakAuras.ForceEvents();

Line 2159 function WeakAuras.ScanForLoads(self, event, arg1)

[Redfella 51]

I'm having no luck duplicating this error, but I did a bit of cleaning up and you could try this export (rota helper): http://pastebin.com/eqQrT2cU

In my development version I'm using UNIT_POWER_FREQUENT and COMBAT_LOG_EVENT instead of Every Frame, so mine isn't probably running anything during load screen and yours could be.

Btw, I've started developing 3.0 which now has working multiple target detection. As far as I've understood, avoiding being Unholy Capped during cleave isn't important and the few Death/Frost runes we spend to avoid being UH capped are lowering our DPS vs. DKs who just mindlessly spam HB.

Sadly Skullflowers guide is offline and I haven't found a reliable source of information about ST vs. AoE priorities and it's slowing me down somewhat.

Edited August 10, 2015 by Redfella

[Raptar 0]

I just made an account to thank you for the WA profiles! They are really great and are helping me bigtime with the rotation!

 

Again thank you and keep it up!

[Vanteria 0]

His guides have been moved to Son of a Lich: http://sonofalich.com/forums/viewtopic.php?f=22&t=77

[Redfella 51]

Thanks Vanteria, this will speed things up.

[Mastermind76 2]

Thanks for the help.  I was reading the link that was posted and read the guide and they say that if you are using Necrotic Plague then you do not want to use plague leach as it resets the stacks on Necrotic Plague.  Redfella I just wanted your opinion on this.  Also thanks for the response I will see if the new rotation works and I will get back to ya.

[Mastermind76 2]

So you will not believe it but it worked perfectly right after i pasted the new rotation.  I then left WOW and came back in and it threw up the error again.  I was like WTF.  Any other suggestions you might have would be appreciated.  Also it does not tell me to do soul reaper.

Edited August 11, 2015 by Mastermind76

[Redfella 51]

Just to make sure, you don't have any older versions of the "Rotation Helper" installed and you've deleted the old helpers before importing newer versions?

 

I think the only way for me to find out what goes wrong is for you to export the string and put it to pastebin.com for me, so I can import and compare differences.

 

Edit: And ofcourse in the meanwhile, you could just go to WoWs built in Interface options and enable hiding errors, until I can get the issue sorted.

 

I'll also doublecheck Soul Reaper, but I don't think I've made any changes to it lately.

Edited August 11, 2015 by Redfella

[ndx101 0]

 

Message: [string "return function()..."]:2: attempt to compare nil with number

Time: 08/08/15 01:21:34

Count: 1

Stack: [C]: ?

[string "return function()..."]:2: in function `trigger'

Interface\AddOns\WeakAuras\WeakAuras.lua:1906: in function `ScanEvents'

Interface\AddOns\WeakAuras\WeakAuras.lua:1820: in function `ForceEvents'

Interface\AddOns\WeakAuras\WeakAuras.lua:2350: in function `ScanForLoads'

...terface\AddOns\WeakAurasOptions\WeakAurasOptions.lua:8285: in function <...terface\AddOns\WeakAurasOptions\WeakAurasOptions.lua:8284>

 

Locals: 

 

I am receiving the same error on the first load.

 

Yeah, I'm getting this one too. Deleted both auras as well as saved variables before importing the versions released a few days ago, no change. Let me know if you need any additional info.

Great work you're doing, though.

[Mastermind76 2]

Here is the link for the way i have it now.  http://pastebin.com/szcpdthy  Also when i import the frost auras string into weakauras it just keeps throwing up errors it will not stop. Just wanted to let you know that as well.

[Taptkeg 2]

Thanks for continuing to work on this, Redfella.  I also appreciate the community's support and feedback to improve the product.

 

I am also receiving the error message the first time I get into combat.  When I close the error window, it doesn't come back.  I'm good with this until the next iteration.

[Redfella 51]

Mastermind76: I re-imported the Aura string and I am not getting errors. I checked that I do not have Swatter/Buggrabber installed (that suppress errors) nor is my "Show Lua Errors" checkbox unchecked in options. I also checked that every trigger is looking for an Aura with a specific spell id, so it should also be compatible with all language versions of the WoW client. 

 

Here's the 3.0 beta string of the Rotation Helper. 

 

3.0 Changes:

- Cleave Mode custom function detects how many targets your last Howling Blast hit. It will reset back to Single Target mode if your next Howling Blast hits only one target, or if you did not cast Howling Blast for 4 seconds.

- Cleave Mode Trigger 1: If target count was 2 or more, suggest Howling Blast over uncapping Unholy Runes

- Cleave Mode Trigger 2: If target count was 3 or more, suggest Death and Decay

Edited August 12, 2015 by Redfella

[Marv 2]

testing 3.0. Problem with

 

- Howling Blast in CleaveMode

- Death and Decay on Aoe Mode

 

 

Message: [string "return function()..."]:2: attempt to concatenate global 'targets_hit' (a nil value)

Time: 08/12/15 12:36:26

Count: 5029

Stack: [string "return function()..."]:2: in function <[string "return function()..."]:1>

Interface\AddOns\WeakAuras\RegionTypes\icon.lua:227: in function `UpdateCustomText'

Interface\AddOns\WeakAuras\WeakAuras.lua:5269: in function <Interface\AddOns\WeakAuras\WeakAuras.lua:5265>

 

Locals: (*temporary) = " 

 

 AOE 

"

(*temporary) = nil

(*temporary) = "attempt to concatenate global 'targets_hit' (a nil value)"

 

 

 

 

 

[Redfella 51]

Seems like setting targets_hit = targets_hit or 0 doesn't cut the error away from the display it tries to access it on. Fixin' right away.

 

Edit: Finally got all the errors show up for myself, seems like disabling Swatter and having Lua Errors Enabled won't make them come back regardless. Anyway, I was able to find Aura display error and the new Cleave Mode error. Will update the string asap.

Edited August 12, 2015 by Redfella

[Marv 2]

mate if i can, can you insert istance ID for zone location about pre-combat? ID is: 669

[Redfella 51]

Fixed: 

2.0.1 Auras: https://gist.githubusercontent.com/rnyberg/0423f72bd905a5a3c539/raw/4226338325a38a994c0adc4e7b991b5880fb3402/DK%2520-%2520Frost%2520DW%2520Auras%25202.0.1%2520(6.2)

- No more errors on login

 

3.0 beta 2 Rotation Helper https://gist.githubusercontent.com/rnyberg/0423f72bd905a5a3c539/raw/e0db49e75ba70ae80f5ae7e4fa240ae21b5220f0/DK%2520-%2520Frost%2520DW%2520Rotation%2520Helper%25203.0%2520beta%25202%2520(6.2)

- No more errors on login

- Localized Hellfire Citadel Zone load rule to work for Non-english clients as well

Edited August 12, 2015 by Redfella

[Redfella 51]

Marv: Give it a go now? :)

[Marv 2]

Marv: Give it a go now?

 

seems work perfectly.

 

tell us how we can thank for this wonderful work you are doing

[Redfella 51]

I don't need much except for gold, since all this coding is taking away from my farming time, but because noone can donate gold crossrealm, I'm out of luck.  It's pretty much enough for me to see that I can help people out.

Edited August 12, 2015 by Redfella

[palles 4]

Excellent work as always man, been using your druid one's on my new bear as well :)

[Redfella 51]

Oh god thats a mess. :D

[palles 4]

works alright ... in fairness bear tanking is so easy that it's mostly just a CD tracker that is a little easier to see :)

[Mastermind76 2]

It works perfectly now. I like the aoe part you added on as well.  Thanks.